Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a test example for Android Studio. #816

Merged
merged 5 commits into from
Jan 6, 2015

Conversation

mdzyuba
Copy link
Contributor

@mdzyuba mdzyuba commented Jan 3, 2015

Hello,

I've exported an android example - cukeulator and cukeulator-test into an Android Studio project and modified build.gradle to use cucumber-jvm.

I've created a README.md and provided information on how to build and run tests.

Hope this will save time and help other cucumber-jvm and Android Studio users.

Thank you,

Mykola

### Setup
Features must be placed in `assets/features/`. Subdirectories are allowed.

The `app/libs` should contain `cucumber-android-*.jar`. Please build it following [cucumber-jvm/android]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not adding it through the build.gradle as well?

e.g. androidTestCompile 'info.cukes:cucumber-android:1.1.8@jar'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sabastian! I wasn't aware of this option. It works for me. I will
update the change.

  • Mykola

On Sat, Jan 3, 2015 at 7:10 AM, Sebastian Gröbler notifications@github.com
wrote:

In examples/android/android-studio/Cukeulator/README.md
#816 (diff)
:

@@ -0,0 +1,60 @@
+## Cukeulator Example Test
+This is the example test-project for the Cukeulator app for Android Studio (Beta) 0.8.14.
+
+### Setup
+Features must be placed in assets/features/. Subdirectories are allowed.
+
+The app/libs should contain cucumber-android-*.jar. Please build it following [cucumber-jvm/android]

why not adding it through the build.gradle as well?

e.g. androidTestCompile 'info.cukes:cucumber-android:1.1.8@jar'


Reply to this email directly or view it on GitHub
https://github.com/cucumber/cucumber-jvm/pull/816/files#r22432069.

@SierraGolf
Copy link
Contributor

This pull request is great, I would like to extend this once it has been merged to also illustrate the usage of the new espresso library.

@mdzyuba
Copy link
Contributor Author

mdzyuba commented Jan 3, 2015

Thanks Sebastian for review!

I've updated the change based on your comments. Please review again.

Thank you,

  • Mykola

The cucumber-android dependency is added as:

```
androidTestCompile 'info.cukes:cucumber-android:1.2.0@jar'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdzyuba this is due to the fact that there is an apklib and a jar file on maven central and jcenter.

@brasmusson / @aslakhellesoy do you know why the project was specified to be packaged as apklib? I think plain jar is sufficient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SierraGolf No, I don't know why the cucumber-android module was specified to be packaged as an apklib. But as the apklib is an maven-android-plugin invented format, could it be that the apklib at the time that cucumber-android was originally created, it was the packaging that was promoted for an Android library project by the maven-android-plugin team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brasmusson apklib does not make any sense to me, since we don't package anything to be used by an app including resources and other android specific things. I will make a pull request to change that.

@SierraGolf
Copy link
Contributor

Alright, thanks for your contribution.

SierraGolf added a commit that referenced this pull request Jan 6, 2015
Added a test example for Android Studio.
@SierraGolf SierraGolf merged commit d54eb55 into cucumber:master Jan 6, 2015
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants